//+------------------------------------------------------------------+
//|                                         macd-momentum-ea.mq4       |
//|  A momentum EA: enters when the MACD line crosses the signal      |
//|  line, with ATR-based Stop Loss/Take Profit and risk-based        |
//|  position sizing. One position at a time.                        |
//|  EDUCATIONAL — test on a demo account first. Past performance     |
//|  does not guarantee future results. This is not financial advice.|
//|  Source: web-forex (educational, free to use and modify)          |
//+------------------------------------------------------------------+
#property copyright "web-forex"
#property strict

extern string ___Strategy___       = "--- MACD Momentum Strategy ---";
extern int    FastEMA              = 12;
extern int    SlowEMA              = 26;
extern int    SignalPeriod         = 9;

extern string ___RiskManagement___ = "--- Risk Management ---";
extern int    ATRPeriod            = 14;
extern double ATRMultiplier        = 2.0;
extern double RiskRewardRatio      = 2.0;
extern bool   UseFixedLot          = false;
extern double FixedLotSize         = 0.01;
extern double RiskPercent          = 1.0;

extern string ___Filters___        = "--- Filters ---";
extern int    MaxSpreadPoints      = 30;

extern string ___General___        = "--- General ---";
extern int    MagicNumber          = 20260719;
extern bool   EnableTrading        = true;

datetime lastBarTime = 0;

int OnInit()
{
   return(INIT_SUCCEEDED);
}

void OnTick()
{
   if (!EnableTrading)
      return;

   if (Time[0] == lastBarTime)
      return; // only evaluate once per new bar
   lastBarTime = Time[0];

   if (CountOpenPositions() > 0)
      return; // one position at a time

   double spreadPoints = MarketInfo(Symbol(), MODE_SPREAD);
   if (spreadPoints > MaxSpreadPoints)
      return; // spread too wide right now, skip this bar

   double macdPrev   = iMACD(NULL, 0, FastEMA, SlowEMA, SignalPeriod, PRICE_CLOSE, MODE_MAIN, 2);
   double signalPrev = iMACD(NULL, 0, FastEMA, SlowEMA, SignalPeriod, PRICE_CLOSE, MODE_SIGNAL, 2);
   double macdLast   = iMACD(NULL, 0, FastEMA, SlowEMA, SignalPeriod, PRICE_CLOSE, MODE_MAIN, 1);
   double signalLast = iMACD(NULL, 0, FastEMA, SlowEMA, SignalPeriod, PRICE_CLOSE, MODE_SIGNAL, 1);
   double atr         = iATR(NULL, 0, ATRPeriod, 1);

   bool bullishCross = (macdPrev <= signalPrev && macdLast > signalLast);
   bool bearishCross = (macdPrev >= signalPrev && macdLast < signalLast);

   if (bullishCross)
      OpenTrade(OP_BUY, atr);
   else if (bearishCross)
      OpenTrade(OP_SELL, atr);
}

int CountOpenPositions()
{
   int count = 0;
   for (int i = 0; i < OrdersTotal(); i++)
   {
      if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
      {
         if (OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber)
            count++;
      }
   }
   return(count);
}

void OpenTrade(int type, double atr)
{
   double slDistance = atr * ATRMultiplier;
   double tpDistance = slDistance * RiskRewardRatio;
   double lots       = CalculateLotSize(slDistance);
   double price, sl, tp;

   if (type == OP_BUY)
   {
      price = Ask;
      sl = price - slDistance;
      tp = price + tpDistance;
   }
   else
   {
      price = Bid;
      sl = price + slDistance;
      tp = price - tpDistance;
   }

   int ticket = OrderSend(Symbol(), type, lots, price, 3, sl, tp, "MACD Momentum EA", MagicNumber, 0,
                          type == OP_BUY ? clrDodgerBlue : clrOrangeRed);
   if (ticket < 0)
      Print("MACD Momentum EA: OrderSend failed, error ", GetLastError());
}

double CalculateLotSize(double slDistance)
{
   if (UseFixedLot || slDistance <= 0)
      return(NormalizeLotSize(FixedLotSize));

   double riskAmount = AccountBalance() * (RiskPercent / 100.0);
   double tickValue   = MarketInfo(Symbol(), MODE_TICKVALUE);
   double tickSize    = MarketInfo(Symbol(), MODE_TICKSIZE);
   if (tickSize <= 0 || tickValue <= 0)
      return(NormalizeLotSize(FixedLotSize));

   double slTicks = slDistance / tickSize;
   double lots    = riskAmount / (slTicks * tickValue);

   return(NormalizeLotSize(lots));
}

double NormalizeLotSize(double lots)
{
   double minLot  = MarketInfo(Symbol(), MODE_MINLOT);
   double maxLot  = MarketInfo(Symbol(), MODE_MAXLOT);
   double lotStep = MarketInfo(Symbol(), MODE_LOTSTEP);
   if (lotStep <= 0)
      return(minLot);

   lots = MathFloor(lots / lotStep) * lotStep;
   if (lots < minLot)
      lots = minLot;
   if (lots > maxLot)
      lots = maxLot;
   return(lots);
}